[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 07/18] iotests: fix 097 when run with qcow
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v5 07/18] iotests: fix 097 when run with qcow |
Date: |
Wed, 22 Feb 2017 17:46:48 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 02/21/2017 05:55 AM, Daniel P. Berrange wrote:
> The previous commit:
>
> commit a3e1505daec31ef56f0489f8c8fff1b8e4ca92bd
> Author: Eric Blake <address@hidden>
> Date: Mon Dec 5 09:49:34 2016 -0600
>
> qcow2: Don't strand clusters near 2G intervals during commit
>
> extended the 097 test case so that it did two passes, once
> with an internal snapshot, once without.
>
> qcow (v1) does not support internal snapshots, so this change
> broke test 097 when run against qcow.
>
> This splits 097 in two, creating a new 173 that tests the
> internal snapshot codepath, effectively putting 097 back
> to its content before the above commit.
>
> Reviewed-by: Max Reitz <address@hidden>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> tests/qemu-iotests/097 | 10 +---
> tests/qemu-iotests/097.out | 125 ++------------------------------------------
> tests/qemu-iotests/175 | 126
> +++++++++++++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/175.out | 119 ++++++++++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/group | 1 +
> 5 files changed, 251 insertions(+), 130 deletions(-)
> create mode 100755 tests/qemu-iotests/175
> create mode 100644 tests/qemu-iotests/175.out
Reviewed-by: Eric Blake <address@hidden>
> +++ b/tests/qemu-iotests/group
> @@ -167,3 +167,4 @@
> 172 auto
> 173 rw auto
> 174 auto
> +175 rw auto backing
I used 175 in v5 of my blkdebug series, but Kevin had comments that are
worth me respinning, so I'm rebasing mine to use 176.
https://lists.gnu.org/archive/html/qemu-devel/2017-02/msg03049.html
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v5 02/18] block: add ability to set a prefix for opt names, (continued)
[Qemu-devel] [PATCH v5 03/18] qcow: document another weakness of qcow AES encryption, Daniel P. Berrange, 2017/02/21
[Qemu-devel] [PATCH v5 05/18] iotests: skip 042 with qcow which dosn't support zero sized images, Daniel P. Berrange, 2017/02/21
[Qemu-devel] [PATCH v5 04/18] qcow: require image size to be > 1 for new images, Daniel P. Berrange, 2017/02/21
[Qemu-devel] [PATCH v5 06/18] iotests: skip 048 with qcow which doesn't support resize, Daniel P. Berrange, 2017/02/21
[Qemu-devel] [PATCH v5 07/18] iotests: fix 097 when run with qcow, Daniel P. Berrange, 2017/02/21
- Re: [Qemu-devel] [PATCH v5 07/18] iotests: fix 097 when run with qcow,
Eric Blake <=
[Qemu-devel] [PATCH v5 08/18] qcow: make encrypt_sectors encrypt in place, Daniel P. Berrange, 2017/02/21
[Qemu-devel] [PATCH v5 09/18] qcow: convert QCow to use QCryptoBlock for encryption, Daniel P. Berrange, 2017/02/21
[Qemu-devel] [PATCH v5 10/18] qcow2: make qcow2_encrypt_sectors encrypt in place, Daniel P. Berrange, 2017/02/21
[Qemu-devel] [PATCH v5 12/18] qcow2: extend specification to cover LUKS encryption, Daniel P. Berrange, 2017/02/21
[Qemu-devel] [PATCH v5 15/18] iotests: enable tests 134 and 158 to work with qcow (v1), Daniel P. Berrange, 2017/02/21
[Qemu-devel] [PATCH v5 14/18] qcow2: add iotests to cover LUKS encryption support, Daniel P. Berrange, 2017/02/21
[Qemu-devel] [PATCH v5 11/18] qcow2: convert QCow2 to use QCryptoBlock for encryption, Daniel P. Berrange, 2017/02/21