Re: [Qemu-devel] [PATCH 05/15] COLO: Handle shutdown command for VM in COLO state

[Hailiang Zhang]

Hi Eric,

On 2017/2/22 23:35, Eric Blake wrote:
> On 02/21/2017 09:42 PM, zhanghailiang wrote:
> > If VM is in COLO FT state, we need to do some extra works before
> > starting normal shutdown process.
> >
> > Secondary VM will ignore the shutdown command if users issue it directly
> > to Secondary VM. COLO will capture shutdown command and after
> > shutdown request from user.
> >
> > Cc: Paolo Bonzini <address@hidden>
> > Signed-off-by: zhanghailiang <address@hidden>
> > Signed-off-by: Li Zhijian <address@hidden>
> > Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> > ---
> > v19:
> > - fix title and comment
>
> Did you miss putting v19 in the subject line?

Er, some patches of this series are split from previous
v18 version, but most patches of that series has been merged
into upstream, so that's why it has a tag here.
I think it is better to remove this comment instead of using
v19 tag for this series.

> > +++ b/qapi-schema.json
> > @@ -1157,12 +1157,14 @@
> >   #
> >   # @vmstate-loaded: VM's state has been loaded by SVM.
> >   #
> > +# @guest-shutdown: shutdown require from PVM to SVM
>
> maybe s/require/requested/ ?

Yes.

> Missing '(since 2.9)'

Will fix this in next version, thanks.

> > +#
> >   # Since: 2.8
> >   ##
> >   { 'enum': 'COLOMessage',
> >     'data': [ 'checkpoint-ready', 'checkpoint-request', 'checkpoint-reply',
> >               'vmstate-send', 'vmstate-size', 'vmstate-received',
> > -            'vmstate-loaded' ] }
> > +            'vmstate-loaded', 'guest-shutdown' ] }