Re: [Qemu-devel] [PATCH 1/8] chardev: Basic support for TN3270

[Cornelia Huck]

On Wed, 22 Feb 2017 09:40:23 -0600
Eric Blake <address@hidden> wrote:

> On 02/22/2017 06:15 AM, Cornelia Huck wrote:
> > From: Jing Liu <address@hidden>
> > 
> > This introduces basic support for TN3270, which needs to negotiate
> > three Telnet options during handshake:
> >   - End of Record
> >   - Binary Transmission
> >   - Terminal-Type
> > 
> > As a basic implementation, this simply ignores NOP and Interrupt
> > Process(IP) commands. More work should be done for them later.
> > 
> > For more details, please refer to RFC 854 and 1576.
> > 
> > Signed-off-by: Jing Liu <address@hidden>
> > Signed-off-by: Yang Chen <address@hidden>
> > Reviewed-by: QingFeng Hao <address@hidden>
> > Acked-by: Dong Jia Shi <address@hidden>
> > Signed-off-by: Cornelia Huck <address@hidden>
> > ---
> 
> > +++ b/qapi-schema.json
> > @@ -4774,6 +4774,8 @@
> >  # @nodelay: #optional set TCP_NODELAY socket option (default: false)
> >  # @telnet: #optional enable telnet protocol on server
> >  #          sockets (default: false)
> > +# @tn3270: #optional enable tn3270 protocol on server
> > +#          sockets (default: false)
> 
> Missing a '(since 2.9)' designation

Thanks, added.

> 
> >  # @reconnect: #optional For a client socket, if a socket is disconnected,
> >  #          then attempt a reconnect after the given number of seconds.
> >  #          Setting this to zero disables this function. (default: 0)
> > @@ -4787,6 +4789,7 @@
> >                                       '*wait'      : 'bool',
> >                                       '*nodelay'   : 'bool',
> >                                       '*telnet'    : 'bool',
> > +                                     '*tn3270'    : 'bool',
> >                                       '*reconnect' : 'int' },
> >    'base': 'ChardevCommon' }
> >  
> > 
>