Re: [Qemu-devel] [PATCH 10/29] 9pfs: local: lsetxattr: don't follow symlinks

[Stefan Hajnoczi]

On Mon, Feb 20, 2017 at 03:40:38PM +0100, Greg Kurz wrote:
> The local_lsetxattr() callback is vulnerable to symlink attacks because
> it calls lsetxattr() which follows symbolic links in all path elements but
> the rightmost one.
> 
> This patch converts local_lsetxattr() to rely on opendir_nofollow() and
> fsetxattrat_nofollow() instead.
> 
> This partly fixes CVE-2016-9602.
> 
> Signed-off-by: Greg Kurz <address@hidden>
> ---
>  hw/9pfs/9p-posix-acl.c  |   18 ++++--------------
>  hw/9pfs/9p-xattr-user.c |    8 +-------
>  hw/9pfs/9p-xattr.c      |    8 +-------
>  3 files changed, 6 insertions(+), 28 deletions(-)

Reviewed-by: Stefan Hajnoczi <address@hidden>

signature.asc
Description: PGP signature