qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 22/29] 9pfs: local: link: don't follow symlinks


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH 22/29] 9pfs: local: link: don't follow symlinks
Date: Thu, 23 Feb 2017 15:01:23 +0000
User-agent: Mutt/1.7.1 (2016-10-04)

On Mon, Feb 20, 2017 at 03:42:11PM +0100, Greg Kurz wrote:
> The local_link() callback is vulnerable to symlink attacks because it calls:
> 
> (1) link() which follows symbolic links for all path elements but the
>     rightmost one
> (2) local_create_mapped_attr_dir()->mkdir() which follows symbolic links
>     for all path elements but the rightmost one
> 
> This patch converts local_link() to rely on opendir_nofollow() and linkat()
> to fix (1), mkdirat() to fix (2).
> 
> This partly fixes CVE-2016-9602.
> 
> Signed-off-by: Greg Kurz <address@hidden>
> ---
>  hw/9pfs/9p-local.c |   86 
> ++++++++++++++++++++++++++++++++++------------------
>  1 file changed, 57 insertions(+), 29 deletions(-)

Reviewed-by: Stefan Hajnoczi <address@hidden>

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]