Re: [Qemu-devel] [PATCH V8 2/2] Add a new qmp command to do checkpoint, query xen replication status

[Zhang Chen]

On 02/23/2017 11:34 PM, Eric Blake wrote:
> On 02/23/2017 01:14 AM, Zhang Chen wrote:
> > We can call this qmp command to do checkpoint outside of qemu.
> > Xen colo will need this function.
> >
> > Signed-off-by: Zhang Chen <address@hidden>
> > Signed-off-by: Wen Congyang <address@hidden>
> > Reviewed-by: Eric Blake <address@hidden>
> You made a substantial change to this patch since v7 in response to my
> comments; when you do that, it's best to remove the R-b to make sure I
> re-review the changes and am still happy with them.

OK, I will remove the R-b in next version.

> > ---
> >   migration/colo.c | 23 +++++++++++++++++++++++
> >   qapi-schema.json | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
> >   2 files changed, 71 insertions(+)
> >
> >   ##
> > +# @ReplicationStatus:
> > +#
> > +# The result format for 'query-xen-replication-status'.
> > +#
> > +# @status: true to error, false to normal.
> This is now a poor name for the parameter.  Please rename it; probably
> to @error (if you want to keep true meaning a problem has been
> detected), or to @okay (if you want to invert the sense, and @desc is
> only present when @okay is false).

I will rename it to "@error" in next version.

> > +#
> > +# @desc: #optional the human readable error description string, when
> > +#        @status is 'true'.
> > +#
> > +# Since: 2.9
> > +##
> > +{ 'struct': 'ReplicationStatus',
> > +  'data': { 'status': 'bool', '*desc': 'str' } }
> > +
> > +##
> > +# @query-xen-replication-status:
> > +#
> > +# Query replication status while the vm is running.
> > +#
> > +# Returns: A @ReplicationResult objects showing the status.
> s/objects/object/

I got it.

> > +#
> > +# Example:
> > +#
> > +# -> { "execute": "query-xen-replication-status" }
> > +# <- { "return": { "status": "normal" } }
> This example is now wrong.
>
> You'll need a v9.

Yes, I will send the V9 later.

Thanks
Zhang Chen

>

--
Thanks
Zhang Chen