[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 6/9] virtio-gpu: use graphic_* variables.
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 6/9] virtio-gpu: use graphic_* variables. |
Date: |
Fri, 24 Feb 2017 10:21:03 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 21/02/2017 23:14, Gerd Hoffmann wrote:
> If graphic_* variables are set (via -g switch), pass on
> that information to the guest so the driver can use it.
>
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> hw/display/virtio-gpu.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
> index 9b530ab..04ba221 100644
> --- a/hw/display/virtio-gpu.c
> +++ b/hw/display/virtio-gpu.c
> @@ -1170,8 +1170,13 @@ static void virtio_gpu_device_realize(DeviceState
> *qdev, Error **errp)
> virtio_init(VIRTIO_DEVICE(g), "virtio-gpu", VIRTIO_ID_GPU,
> g->config_size);
>
> - g->req_state[0].width = 1024;
> - g->req_state[0].height = 768;
> + if (graphic_width && graphic_height) {
> + g->req_state[0].width = graphic_width;
> + g->req_state[0].height = graphic_height;
> + } else {
> + g->req_state[0].width = 1024;
> + g->req_state[0].height = 768;
> + }
What about adding properties for this, and only using graphic_* as a
fallback?
Paolo
> if (virtio_gpu_virgl_enabled(g->conf)) {
> /* use larger control queue in 3d mode */
>
- [Qemu-devel] [PATCH 0/9] wire up -g <width>x<height> switch for virtio and qxl., Gerd Hoffmann, 2017/02/21
- [Qemu-devel] [PATCH 6/9] virtio-gpu: use graphic_* variables., Gerd Hoffmann, 2017/02/21
- Re: [Qemu-devel] [PATCH 6/9] virtio-gpu: use graphic_* variables.,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 5/9] enable -g command line switch for all archs, Gerd Hoffmann, 2017/02/21
- [Qemu-devel] [PATCH 8/9] update -g command line switch documentation, Gerd Hoffmann, 2017/02/21
- [Qemu-devel] [PATCH 3/9] ppc: use ppc_graphic_* defines, Gerd Hoffmann, 2017/02/21
- [Qemu-devel] [PATCH 7/9] qxl: use graphic_* variables., Gerd Hoffmann, 2017/02/21