[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 13/13] armv7m: Allow SHCSR writes to change p
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH v2 13/13] armv7m: Allow SHCSR writes to change pending and active bits |
Date: |
Fri, 24 Feb 2017 17:17:13 +0000 |
User-agent: |
mu4e 0.9.19; emacs 25.2.5 |
Peter Maydell <address@hidden> writes:
> Implement the NVIC SHCSR write behaviour which allows pending and
> active status of some exceptions to be changed.
>
> Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
> ---
> hw/intc/armv7m_nvic.c | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/hw/intc/armv7m_nvic.c b/hw/intc/armv7m_nvic.c
> index a8c5a9e..1d34e0d 100644
> --- a/hw/intc/armv7m_nvic.c
> +++ b/hw/intc/armv7m_nvic.c
> @@ -755,8 +755,17 @@ static void nvic_writel(NVICState *s, uint32_t offset,
> uint32_t value)
> cpu->env.v7m.ccr = value;
> break;
> case 0xd24: /* System Handler Control. */
> - /* TODO: Real hardware allows you to set/clear the active bits
> - under some circumstances. We don't implement this. */
> + s->vectors[ARMV7M_EXCP_MEM].active = (value & (1 << 0)) != 0;
> + s->vectors[ARMV7M_EXCP_BUS].active = (value & (1 << 1)) != 0;
> + s->vectors[ARMV7M_EXCP_USAGE].active = (value & (1 << 3)) != 0;
> + s->vectors[ARMV7M_EXCP_SVC].active = (value & (1 << 7)) != 0;
> + s->vectors[ARMV7M_EXCP_DEBUG].active = (value & (1 << 8)) != 0;
> + s->vectors[ARMV7M_EXCP_PENDSV].active = (value & (1 << 10)) != 0;
> + s->vectors[ARMV7M_EXCP_SYSTICK].active = (value & (1 << 11)) != 0;
> + s->vectors[ARMV7M_EXCP_USAGE].pending = (value & (1 << 12)) != 0;
> + s->vectors[ARMV7M_EXCP_MEM].pending = (value & (1 << 13)) != 0;
> + s->vectors[ARMV7M_EXCP_BUS].pending = (value & (1 << 14)) != 0;
> + s->vectors[ARMV7M_EXCP_SVC].pending = (value & (1 << 15)) != 0;
> s->vectors[ARMV7M_EXCP_MEM].enabled = (value & (1 << 16)) != 0;
> s->vectors[ARMV7M_EXCP_BUS].enabled = (value & (1 << 17)) != 0;
> s->vectors[ARMV7M_EXCP_USAGE].enabled = (value & (1 << 18)) != 0;
--
Alex Bennée
- [Qemu-devel] [PATCH v2 00/13] Rewrite NVIC to not depend on the GIC, Peter Maydell, 2017/02/16
- [Qemu-devel] [PATCH v2 02/13] armv7m: Implement reading and writing of PRIGROUP, Peter Maydell, 2017/02/16
- [Qemu-devel] [PATCH v2 12/13] armv7m: Raise correct kind of UsageFault for attempts to execute ARM code, Peter Maydell, 2017/02/16
- [Qemu-devel] [PATCH v2 10/13] armv7m: Extract "exception taken" code into functions, Peter Maydell, 2017/02/16
- [Qemu-devel] [PATCH v2 13/13] armv7m: Allow SHCSR writes to change pending and active bits, Peter Maydell, 2017/02/16
- Re: [Qemu-devel] [PATCH v2 13/13] armv7m: Allow SHCSR writes to change pending and active bits,
Alex Bennée <=
- [Qemu-devel] [PATCH v2 09/13] armv7m: VECTCLRACTIVE and VECTRESET are UNPREDICTABLE, Peter Maydell, 2017/02/16
- [Qemu-devel] [PATCH v2 11/13] armv7m: Check exception return consistency, Peter Maydell, 2017/02/16
- [Qemu-devel] [PATCH v2 08/13] armv7m: Simpler and faster exception start, Peter Maydell, 2017/02/16
- [Qemu-devel] [PATCH v2 07/13] armv7m: Remove unused armv7m_nvic_acknowledge_irq() return value, Peter Maydell, 2017/02/16
- [Qemu-devel] [PATCH v2 06/13] armv7m: Escalate exceptions to HardFault if necessary, Peter Maydell, 2017/02/16
- [Qemu-devel] [PATCH v2 05/13] arm: gic: Remove references to NVIC, Peter Maydell, 2017/02/16
- [Qemu-devel] [PATCH v2 04/13] armv7m: Fix condition check for taking exceptions, Peter Maydell, 2017/02/16
- [Qemu-devel] [PATCH v2 01/13] armv7m: Rename nvic_state to NVICState, Peter Maydell, 2017/02/16
- [Qemu-devel] [PATCH v2 03/13] armv7m: Rewrite NVIC to not use any GIC code, Peter Maydell, 2017/02/16