[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 10/16] postcopy: Mask fault addresses to huge pag
From: |
Dr. David Alan Gilbert (git) |
Subject: |
[Qemu-devel] [PATCH v3 10/16] postcopy: Mask fault addresses to huge page boundary |
Date: |
Fri, 24 Feb 2017 18:28:38 +0000 |
From: "Dr. David Alan Gilbert" <address@hidden>
Currently the fault address received by userfault is rounded to
the host page boundary and a host page is requested from the source.
Use the current RAMBlock page size instead of the general host page
size so that for RAMBlocks backed by huge pages we request the whole
huge page.
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
---
migration/postcopy-ram.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c
index 4c736d2..03cbd6e 100644
--- a/migration/postcopy-ram.c
+++ b/migration/postcopy-ram.c
@@ -403,7 +403,6 @@ static void *postcopy_ram_fault_thread(void *opaque)
MigrationIncomingState *mis = opaque;
struct uffd_msg msg;
int ret;
- size_t hostpagesize = getpagesize();
RAMBlock *rb = NULL;
RAMBlock *last_rb = NULL; /* last RAMBlock we sent part of */
@@ -470,7 +469,7 @@ static void *postcopy_ram_fault_thread(void *opaque)
break;
}
- rb_offset &= ~(hostpagesize - 1);
+ rb_offset &= ~(qemu_ram_pagesize(rb) - 1);
trace_postcopy_ram_fault_thread_request(msg.arg.pagefault.address,
qemu_ram_get_idstr(rb),
rb_offset);
@@ -482,11 +481,11 @@ static void *postcopy_ram_fault_thread(void *opaque)
if (rb != last_rb) {
last_rb = rb;
migrate_send_rp_req_pages(mis, qemu_ram_get_idstr(rb),
- rb_offset, hostpagesize);
+ rb_offset, qemu_ram_pagesize(rb));
} else {
/* Save some space */
migrate_send_rp_req_pages(mis, NULL,
- rb_offset, hostpagesize);
+ rb_offset, qemu_ram_pagesize(rb));
}
}
trace_postcopy_ram_fault_thread_exit();
--
2.9.3
- [Qemu-devel] [PATCH v3 00/16] Postcopy: Hugepage support, Dr. David Alan Gilbert (git), 2017/02/24
- [Qemu-devel] [PATCH v3 02/16] postcopy: Transmit and compare individual page sizes, Dr. David Alan Gilbert (git), 2017/02/24
- [Qemu-devel] [PATCH v3 01/16] postcopy: Transmit ram size summary word, Dr. David Alan Gilbert (git), 2017/02/24
- [Qemu-devel] [PATCH v3 03/16] postcopy: Chunk discards for hugepages, Dr. David Alan Gilbert (git), 2017/02/24
- [Qemu-devel] [PATCH v3 04/16] exec: ram_block_discard_range, Dr. David Alan Gilbert (git), 2017/02/24
- [Qemu-devel] [PATCH v3 06/16] postcopy: Record largest page size, Dr. David Alan Gilbert (git), 2017/02/24
- [Qemu-devel] [PATCH v3 08/16] postcopy: Use temporary for placing zero huge pages, Dr. David Alan Gilbert (git), 2017/02/24
- [Qemu-devel] [PATCH v3 05/16] postcopy: enhance ram_block_discard_range for hugepages, Dr. David Alan Gilbert (git), 2017/02/24
- [Qemu-devel] [PATCH v3 07/16] postcopy: Plumb pagesize down into place helpers, Dr. David Alan Gilbert (git), 2017/02/24
- [Qemu-devel] [PATCH v3 10/16] postcopy: Mask fault addresses to huge page boundary,
Dr. David Alan Gilbert (git) <=
- [Qemu-devel] [PATCH v3 09/16] postcopy: Load huge pages in one go, Dr. David Alan Gilbert (git), 2017/02/24
- [Qemu-devel] [PATCH v3 12/16] postcopy: Allow hugepages, Dr. David Alan Gilbert (git), 2017/02/24
- [Qemu-devel] [PATCH v3 11/16] postcopy: Send whole huge pages, Dr. David Alan Gilbert (git), 2017/02/24
- [Qemu-devel] [PATCH v3 14/16] postcopy: Check for userfault+hugepage feature, Dr. David Alan Gilbert (git), 2017/02/24
- [Qemu-devel] [PATCH v3 13/16] postcopy: Update userfaultfd.h header, Dr. David Alan Gilbert (git), 2017/02/24
- [Qemu-devel] [PATCH v3 15/16] postcopy: Add doc about hugepages and postcopy, Dr. David Alan Gilbert (git), 2017/02/24
- [Qemu-devel] [PATCH v3 16/16] postcopy: Add extra check for COPY function, Dr. David Alan Gilbert (git), 2017/02/24