Re: [Qemu-devel] [PATCH V9 2/2] Add a new qmp command to do checkpoint, query xen replication status

[Zhang Chen]

On 02/25/2017 01:27 AM, Eric Blake wrote:
> On 02/24/2017 01:22 AM, Zhang Chen wrote:
> > We can call this qmp command to do checkpoint outside of qemu.
> > Xen colo will need this function.
> >
> > Signed-off-by: Zhang Chen <address@hidden>
> > Signed-off-by: Wen Congyang <address@hidden>
> > ---
> >   migration/colo.c | 23 +++++++++++++++++++++++
> >   qapi-schema.json | 49 +++++++++++++++++++++++++++++++++++++++++++++++++
> >   2 files changed, 72 insertions(+)
> >
> > +++ b/qapi-schema.json
> > @@ -5931,6 +5931,55 @@
> >     'data': { 'enable': 'bool', 'primary': 'bool', '*failover' : 'bool' } }
> >   
> >   ##
> > +# @ReplicationStatus:
> > +#
> > +# The result format for 'query-xen-replication-status'.
> > +#
> > +# @error: true to error, false to normal.
> Maybe:
>
> true if an error happened, false if replication is normal
>
> Maintainer could touch that up during application, so it doesn't
> necessarily require a v10.

Maintainer may be very busy, I will do this fix in V10.

> > +##
> > +# @query-xen-replication-status:
> > +#
> > +# Query replication status while the vm is running.
> > +#
> > +# Returns: A @ReplicationResult object showing the status.
> > +#
> > +# Example:
> > +#
> > +# -> { "execute": "query-xen-replication-status" }
> > +# <- { "return": [ { "error": false },
> > +#                  { "error": true } ] }
> This example is bogus.  The command does NOT return an array.  It is
> sufficient to use:
>
> { "return": { "error": false } }
>
> but if you want, you could instead do:
>
> { "return": { "error": true, "desc": "..." } }
>
> but if you do that, please be sure that desc matches an actual error
> code that could occur, and not something made up.
>
> If all you do is fix the example with the simpler "error":false (and
> maybe the maintainer is okay doing that), then you can add:
> Reviewed-by: Eric Blake <address@hidden>

I will fix the example in V10, and which maintainer can pick up this patch?

Thanks
Zhang Chen


--
Thanks
Zhang Chen