Re: [Qemu-devel] [PATCH 40/54] block: BdrvChildRole.attach/detach() callbacks

[Max Reitz]

On 21.02.2017 15:58, Kevin Wolf wrote:
> Backing files are somewhat special compared to other kinds of children
> because they are attached and detached using bdrv_set_backing_hd()
> rather than the normal set of functions, which does a few more things
> like setting backing blockers, toggling the BDRV_O_NO_BACKING flag,
> setting parent_bs->backing_file, etc.
> 
> These special features are a reason why change_parent_backing_link()
> can't handle backing files yet. With abstracting the additional features
> into .attach/.detach callbacks, we get a step closer to a function that
> can actually deal with this.
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block.c                   | 94 
> +++++++++++++++++++++++++++++------------------
>  include/block/block_int.h |  3 ++
>  2 files changed, 62 insertions(+), 35 deletions(-)

Reviewed-by: Max Reitz <address@hidden>

signature.asc
Description: OpenPGP digital signature