[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-s390x: Implement lpp instruction
|
From: |
Miroslav Benes |
|
Subject: |
Re: [Qemu-devel] [PATCH] target-s390x: Implement lpp instruction |
|
Date: |
Mon, 27 Feb 2017 09:51:07 +0100 (CET) |
|
User-agent: |
Alpine 2.20 (LSU 67 2015-01-07) |
On Sat, 25 Feb 2017, Richard Henderson wrote:
> On 02/25/2017 12:50 AM, Miroslav Benes wrote:
> > Linux arch/s390/kernel/head(64).S uses lpp instruction if it is
> > available in facilities list provided by stfl/stfle instruction. This is
> > the case of newer z/System generations and their qemu definition.
> >
> > Signed-off-by: Miroslav Benes <address@hidden>
> > ---
>
> I can't find LPP in my PoO 11th edition...
>
> > +static ExitStatus op_lpp(DisasContext *s, DisasOps *o)
> > +{
> > + check_privileged(s);
> > + potential_page_fault(s);
> > +
> > + tcg_gen_st_i64(o->in2, cpu_env, offsetof(CPUS390XState, pp));
>
> But you don't need the potential_page_fault, since this is not a store to
> guest memory.
Right. I got confused by Access Program Exception in the spec. Sending v2.
Thanks for the review!
Miroslav