[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Adding support for LPD and LPDG instructions
|
From: |
Éric Bischoff |
|
Subject: |
Re: [Qemu-devel] [PATCH] Adding support for LPD and LPDG instructions |
|
Date: |
Mon, 27 Feb 2017 11:48:20 +0100 |
|
User-agent: |
KMail/5.2.3 (Linux/4.8.0-34-generic; KDE/5.26.0; x86_64; ; ) |
Le samedi 25 février 2017, 10:42:43 CET Richard Henderson a écrit :
> On 02/23/2017 10:58 PM, Eric Bischoff wrote:
> > +/* LOAD PAIR DISJOINT */
> > + C(0xc804, LPD, SSF, ILA, m1_32s, m2_32s, 0, r3_P32, movx, 0)
> > + C(0xc805, LPDG, SSF, ILA, m1_64, m2_64, 0, r3_P64, movx, 0)
>
> Missing is the update to the condition codes.
> I think just setting CC = 3 (not loaded interlocked) is probably fine.
I tested and 0 at the end of C macro means "do nothing with CC".
I indeed need to set CC (but to 0, not to 3). New patch coming.
--
Eric Bischoff - SUSE Manager QA Engineer
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip
Upmanyu, Graham Norton, HRB 21284 (AG Nürnberg)Le dimanche 26 février 2017,