[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v16 08/22] qcow2: add bitmaps extension
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v16 08/22] qcow2: add bitmaps extension |
Date: |
Mon, 27 Feb 2017 13:27:13 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 |
On 25.02.2017 18:07, Vladimir Sementsov-Ogievskiy wrote:
> Add bitmap extension as specified in docs/specs/qcow2.txt.
> For now, just mirror extension header into Qcow2 state and check
> constraints. Also, calculate refcounts for qcow2 bitmaps, to not break
> qemu-img check.
>
> For now, disable image resize if it has bitmaps. It will be fixed later.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
> block/Makefile.objs | 2 +-
> block/qcow2-bitmap.c | 439
> +++++++++++++++++++++++++++++++++++++++++++++++++
> block/qcow2-refcount.c | 6 +
> block/qcow2.c | 124 +++++++++++++-
> block/qcow2.h | 27 +++
> 5 files changed, 592 insertions(+), 6 deletions(-)
> create mode 100644 block/qcow2-bitmap.c
Somehow I have the feeling Kevin will find bad things in this patch, but
since I have already approved of all of the previous patches this one is
composed of and the changes on top of that look OK to me:
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v16 19/22] iotests: test qcow2 persistent dirty bitmap, (continued)
- [Qemu-devel] [PATCH v16 19/22] iotests: test qcow2 persistent dirty bitmap, Vladimir Sementsov-Ogievskiy, 2017/02/25
- [Qemu-devel] [PATCH v16 02/22] specs/qcow2: do not use wording 'bitmap header', Vladimir Sementsov-Ogievskiy, 2017/02/25
- [Qemu-devel] [PATCH v16 14/22] block: add bdrv_can_store_new_dirty_bitmap, Vladimir Sementsov-Ogievskiy, 2017/02/25
- [Qemu-devel] [PATCH v16 05/22] block: fix bdrv_dirty_bitmap_granularity signature, Vladimir Sementsov-Ogievskiy, 2017/02/25
- [Qemu-devel] [PATCH v16 18/22] qmp: add x-debug-block-dirty-bitmap-sha256, Vladimir Sementsov-Ogievskiy, 2017/02/25
- [Qemu-devel] [PATCH v16 21/22] qcow2: add .bdrv_remove_persistent_dirty_bitmap, Vladimir Sementsov-Ogievskiy, 2017/02/25
- [Qemu-devel] [PATCH v16 01/22] specs/qcow2: fix bitmap granularity qemu-specific note, Vladimir Sementsov-Ogievskiy, 2017/02/25
- [Qemu-devel] [PATCH v16 13/22] qcow2: add persistent dirty bitmaps support, Vladimir Sementsov-Ogievskiy, 2017/02/25
- [Qemu-devel] [PATCH v16 08/22] qcow2: add bitmaps extension, Vladimir Sementsov-Ogievskiy, 2017/02/25
- Re: [Qemu-devel] [PATCH v16 08/22] qcow2: add bitmaps extension,
Max Reitz <=
- [Qemu-devel] [PATCH v16 04/22] tests: add hbitmap iter test, Vladimir Sementsov-Ogievskiy, 2017/02/25
- [Qemu-devel] [PATCH v16 12/22] block/dirty-bitmap: add bdrv_dirty_bitmap_next(), Vladimir Sementsov-Ogievskiy, 2017/02/25
- [Qemu-devel] [PATCH v16 03/22] hbitmap: improve dirty iter, Vladimir Sementsov-Ogievskiy, 2017/02/25
- [Qemu-devel] [PATCH v16 15/22] qcow2: add .bdrv_can_store_new_dirty_bitmap, Vladimir Sementsov-Ogievskiy, 2017/02/25
- [Qemu-devel] [PATCH v16 22/22] qmp: block-dirty-bitmap-remove: remove persistent, Vladimir Sementsov-Ogievskiy, 2017/02/25
- [Qemu-devel] [PATCH v16 09/22] qcow2: autoloading dirty bitmaps, Vladimir Sementsov-Ogievskiy, 2017/02/25
- [Qemu-devel] [PATCH v16 07/22] qcow2-refcount: rename inc_refcounts() and make it public, Vladimir Sementsov-Ogievskiy, 2017/02/25