[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 15/54] block: Involve block drivers in permissio
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH 15/54] block: Involve block drivers in permission granting |
|
Date: |
Mon, 27 Feb 2017 13:28:42 +0100 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 22.02.2017 um 15:04 hat Max Reitz geschrieben:
> > @@ -1390,6 +1565,7 @@ BdrvChild *bdrv_root_attach_child(BlockDriverState
> > *child_bs,
> >
> > ret = bdrv_check_update_perm(child_bs, perm, shared_perm, NULL, errp);
> > if (ret < 0) {
> > + bdrv_abort_perm_update(child_bs);
> > return NULL;
> > }
> >
>
> This function doesn't call bdrv_set_perm(). Intentional?
Yes, intentional. It calls it indirectly via bdrv_replace_child(). I'll
add a comment.
Kevin
pgpN7Efgh6imh.pgp
Description: PGP signature