qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 12/30] tests: fix bios-tables-test leak


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v2 12/30] tests: fix bios-tables-test leak
Date: Mon, 27 Feb 2017 15:03:30 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

Marc-André Lureau <address@hidden> writes:

> The inside array should be free too.
> Spotted by ASAN.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  tests/bios-tables-test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c
> index 54048050c0..d54018da73 100644
> --- a/tests/bios-tables-test.c
> +++ b/tests/bios-tables-test.c
> @@ -144,7 +144,7 @@ static void free_test_data(test_data *data)
>          g_free(temp->asl_file);
>      }
>  
> -    g_array_free(data->tables, false);
> +    g_array_free(data->tables, true);
>  }
>  
>  static uint8_t acpi_checksum(const uint8_t *data, int len)

Reviewed-by: Markus Armbruster <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]