Re: [Qemu-devel] [PATCH v2 13/26] qapi: Drop string input visitor method optional()

[Eric Blake]

On 02/26/2017 03:43 PM, Markus Armbruster wrote:
> visit_optional() is to be called only between visit_start_struct() and
> visit_end_struct().  Visitors that don't support struct visits,
> i.e. don't implement start_struct(), end_struct(), have no use for it.
> Clarify documentation.
> 
> The string input visitor doesn't support struct visits.  Its
> parse_optional() is therefore useless.  Drop it.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  include/qapi/visitor-impl.h |  4 ++--
>  qapi/string-input-visitor.c | 13 -------------
>  2 files changed, 2 insertions(+), 15 deletions(-)
> 

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature