[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] pl190: Fix off-by-one error in priority handlin
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH] pl190: Fix off-by-one error in priority handling when reading VECTADDR |
|
Date: |
Mon, 27 Feb 2017 16:53:09 +0000 |
On 27 February 2017 at 16:42, Marc Bommert <address@hidden> wrote:
> Hello Peter, you are completely right. The bug isn't in master
> and my patch is to be rejected. There was once a version of pl190.c
> (like uhhm, around 2011) which didn't have the [i+1] in the array
> index and somehow (please don't ask) it made it into my qemu build.
Ah, yes -- commit 14c126baf1c was that bugfix.
> Thank you for pointing this out.
No problem -- glad we've figured out what's going on.
(You should probably check you don't have any other ancient
wrong copies of source files lying around :-))
thanks
-- PMM