[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 15/26] qom: Make object_property_set_qobject(
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 15/26] qom: Make object_property_set_qobject()'s input visitor strict |
Date: |
Mon, 27 Feb 2017 13:25:51 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 02/26/2017 03:43 PM, Markus Armbruster wrote:
> Commit 240f64b made all qobject input visitors created outside tests
> strict, except for the one in object_property_set_qobject(). That one
> was left behind only because Eric couldn't spare the time to figure
> out whether making it strict would break anything, with a TODO
> comment. Time to resolve it.
>
> Strict makes a difference only for otherwise successful visits of QAPI
> structs or unions. Let's examine what the callers of
> object_property_set_qobject() visit:
>
> * object_property_set_str(), object_property_set_bool(),
> object_property_set_int() visit a QString, QBool, QInt,
> respectively. Strictness can't matter.
>
> * qmp_qom_set visits its @value argument. Comes straight from QMP and
> can be anything ('any' in the QAPI schema). Strictness matters when
> the property's set() method visits a struct or union QAPI type.
>
> No such methods exist, thus switching to strict can't break
> anything.
>
> If we acquire such methods in the future, we'll *want* the visitor
> to be strict, so that unexpected members get rejected as they should
> be.
>
> Switch to strict.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> qom/qom-qobject.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v2 25/26] qapi: Fix object input visit beyond end of list, (continued)
- [Qemu-devel] [PATCH v2 06/26] qmp: Drop duplicated QMP command object checks, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 26/26] qapi: Improve qobject visitor documentation, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 16/26] test-qobject-input-visitor: Use strict visitor, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 09/26] qapi: Improve a QObject input visitor error message, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 05/26] qmp: Clean up how we enforce capability negotiation, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 15/26] qom: Make object_property_set_qobject()'s input visitor strict, Markus Armbruster, 2017/02/26
- Re: [Qemu-devel] [PATCH v2 15/26] qom: Make object_property_set_qobject()'s input visitor strict,
Eric Blake <=
- [Qemu-devel] [PATCH v2 14/26] qapi: Make string input and opts visitor require non-null input, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 03/26] qmp-test: New, covering basic QMP protocol, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 07/26] qmp: Eliminate silly QERR_QMP_* macros, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 21/26] tests: Cover partial input visit of list, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 24/26] tests: Cover input visit beyond end of list, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 20/26] test-string-input-visitor: Improve list coverage, Markus Armbruster, 2017/02/26