Re: [Qemu-devel] [PATCH] Adding support for LPD and LPDG instructions

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Type: series
Subject: [Qemu-devel] [PATCH] Adding support for LPD and LPDG instructions

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
f7359bd Adding support for LPD and LPDG instructions

=== OUTPUT BEGIN ===
Checking PATCH 1/1: Adding support for LPD and LPDG instructions...
ERROR: suspect code indent for conditional statements (6, 11)
#46: FILE: target/s390x/translate.c:2759:
+      if (parallel_cpus) {
+           potential_page_fault(s);

ERROR: suspect code indent for conditional statements (4, 9)
#69: FILE: target/s390x/translate.c:2782:
+    if (parallel_cpus) {
+         potential_page_fault(s);

ERROR: Missing Signed-off-by: line(s)

total: 3 errors, 0 warnings, 91 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden