Re: [Qemu-devel] [PATCH v3 00/26] qapi: QMP dispatch and input visitor work

[Eric Blake]

On 02/28/2017 12:03 PM, address@hidden wrote:
> Hi,
> 
> This series seems to have some coding style problems. See output below for
> more information:
> 

> Checking PATCH 18/26: tests-qobject-input-strict: Merge into 
> test-qobject-input-visitor...
> ERROR: line over 90 characters
> #486: FILE: tests/test-qobject-input-visitor.c:847:
> +    v = visitor_input_test_init(data, "{ 'integer': -42, 'boolean': true, 
> 'string': 'foo', 'extra': 42 }");

Code motion, can be ignored (we may want to clean it up later, but
doesn't affect this series).


> Checking PATCH 24/26: tests: Cover input visit beyond end of list...
> ERROR: if this code is redundant consider removing it
> #85: FILE: tests/test-qobject-input-visitor.c:956:
> +#if 0 /* FIXME crash */

Fixed later in the series, so doesn't impact the overall submission.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature