[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 01/24] test-qemu-opts: Cover qemu_opts_parse() of "no
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PULL 01/24] test-qemu-opts: Cover qemu_opts_parse() of "no" |
Date: |
Tue, 28 Feb 2017 23:25:52 +0100 |
qemu_opts_parse() interprets "no" as negated empty key. Consistent
with its acceptance of empty keys elsewhere, whatever that's worth.
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
Message-Id: <address@hidden>
---
tests/test-qemu-opts.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/tests/test-qemu-opts.c b/tests/test-qemu-opts.c
index c46ef31..f6310b3 100644
--- a/tests/test-qemu-opts.c
+++ b/tests/test-qemu-opts.c
@@ -532,6 +532,11 @@ static void test_opts_parse(void)
g_assert_cmpstr(qemu_opt_get(opts, "aus"), ==, "off");
g_assert_cmpstr(qemu_opt_get(opts, "noaus"), ==, "");
+ /* Implied value, negated empty key */
+ opts = qemu_opts_parse(&opts_list_03, "no", false, &error_abort);
+ g_assert_cmpuint(opts_count(opts), ==, 1);
+ g_assert_cmpstr(qemu_opt_get(opts, ""), ==, "off");
+
/* Implied key */
opts = qemu_opts_parse(&opts_list_03, "an,noaus,noaus=", true,
&error_abort);
--
2.7.4
- [Qemu-devel] [PULL 00/24] block: Command line option -blockdev, Markus Armbruster, 2017/02/28
- [Qemu-devel] [PULL 02/24] tests: Fix gcov-files-test-qemu-opts-y, gcov-files-test-logging-y, Markus Armbruster, 2017/02/28
- [Qemu-devel] [PULL 09/24] libqtest: Fix qmp() & friends to abort on JSON parse errors, Markus Armbruster, 2017/02/28
- [Qemu-devel] [PULL 10/24] qjson: Abort earlier on qobject_from_jsonf() misuse, Markus Armbruster, 2017/02/28
- [Qemu-devel] [PULL 07/24] qapi: Factor out common qobject_input_get_keyval(), Markus Armbruster, 2017/02/28
- [Qemu-devel] [PULL 06/24] qapi: Factor out common part of qobject input visitor creation, Markus Armbruster, 2017/02/28
- [Qemu-devel] [PULL 03/24] keyval: New keyval_parse(), Markus Armbruster, 2017/02/28
- [Qemu-devel] [PULL 20/24] qapi: New qobject_input_visitor_new_str() for convenience, Markus Armbruster, 2017/02/28
- [Qemu-devel] [PULL 15/24] test-visitor-serialization: Pass &error_abort to qobject_from_json(), Markus Armbruster, 2017/02/28
- [Qemu-devel] [PULL 01/24] test-qemu-opts: Cover qemu_opts_parse() of "no",
Markus Armbruster <=
- [Qemu-devel] [PULL 16/24] monitor: Assert qmp_schema_json[] is sane, Markus Armbruster, 2017/02/28
- [Qemu-devel] [PULL 08/24] qobject: Propagate parse errors through qobject_from_jsonv(), Markus Armbruster, 2017/02/28
- [Qemu-devel] [PULL 11/24] test-qobject-input-visitor: Abort earlier on bad test input, Markus Armbruster, 2017/02/28
- [Qemu-devel] [PULL 19/24] keyval: Restrict key components to valid QAPI names, Markus Armbruster, 2017/02/28
- [Qemu-devel] [PULL 04/24] qapi: qobject input visitor variant for use with keyval_parse(), Markus Armbruster, 2017/02/28
- [Qemu-devel] [PULL 22/24] qapi: Improve how keyval input visitor reports unexpected dicts, Markus Armbruster, 2017/02/28
- [Qemu-devel] [PULL 12/24] qobject: Propagate parse errors through qobject_from_json(), Markus Armbruster, 2017/02/28
- [Qemu-devel] [PULL 17/24] test-qapi-util: New, covering qapi/qapi-util.c, Markus Armbruster, 2017/02/28
- [Qemu-devel] [PULL 23/24] docs/qapi-code-gen.txt: Clarify naming rules, Markus Armbruster, 2017/02/28
- [Qemu-devel] [PULL 05/24] test-keyval: Cover use with qobject input visitor, Markus Armbruster, 2017/02/28