[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 08/30] tests: fix q35-test leaks
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 08/30] tests: fix q35-test leaks |
Date: |
Tue, 28 Feb 2017 17:05:31 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 02/21/2017 08:14 AM, Marc-André Lureau wrote:
> Spotted by ASAN.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> tests/q35-test.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tests/q35-test.c b/tests/q35-test.c
> index 763fe3d6ae..e010d781e7 100644
> --- a/tests/q35-test.c
> +++ b/tests/q35-test.c
> @@ -71,6 +71,9 @@ static void test_smram_lock(void)
> g_assert(smram_test_bit(pcidev, MCH_HOST_BRIDGE_SMRAM_D_OPEN) == false);
> smram_set_bit(pcidev, MCH_HOST_BRIDGE_SMRAM_D_OPEN, true);
> g_assert(smram_test_bit(pcidev, MCH_HOST_BRIDGE_SMRAM_D_OPEN) == true);
> +
> + qpci_free_pc(pcibus);
> + g_free(pcidev);
I might have cleaned pcidev first (reverse order cleanup, since it was
initialized after pcibus), but I don't see any use-after-free problems
in your choice of order.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v2 01/30] qtest: fix a memory leak, (continued)
- [Qemu-devel] [PATCH v2 02/30] tests: fix qmp response leak, Marc-André Lureau, 2017/02/21
- [Qemu-devel] [PATCH v2 04/30] timer: use an inline function for free, Marc-André Lureau, 2017/02/21
- [Qemu-devel] [PATCH v2 03/30] tests: fix leaks in test-io-channel-command, Marc-André Lureau, 2017/02/21
- [Qemu-devel] [PATCH v2 05/30] glib-compat: add g_test_add_data_func_full fallback, Marc-André Lureau, 2017/02/21
- [Qemu-devel] [PATCH v2 06/30] tests: fix ptimer leaks, Marc-André Lureau, 2017/02/21
- [Qemu-devel] [PATCH v2 08/30] tests: fix q35-test leaks, Marc-André Lureau, 2017/02/21
- Re: [Qemu-devel] [PATCH v2 08/30] tests: fix q35-test leaks,
Eric Blake <=
- [Qemu-devel] [PATCH v2 07/30] tests: fix endianness-test leaks, Marc-André Lureau, 2017/02/21
- [Qemu-devel] [PATCH v2 09/30] tests: fix vhost-user-test leaks, Marc-André Lureau, 2017/02/21
- [Qemu-devel] [PATCH v2 10/30] tests: fix ide-test leaks, Marc-André Lureau, 2017/02/21
- [Qemu-devel] [PATCH v2 11/30] tests: fix hd-geo-test leaks, Marc-André Lureau, 2017/02/21
- [Qemu-devel] [PATCH v2 12/30] tests: fix bios-tables-test leak, Marc-André Lureau, 2017/02/21
- [Qemu-devel] [PATCH v2 14/30] tests: fix ipmi-bt-test leak, Marc-André Lureau, 2017/02/21