[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 29/30] tests: fix virtio-blk-test leaks
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 29/30] tests: fix virtio-blk-test leaks |
|
Date: |
Tue, 28 Feb 2017 17:22:23 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 02/21/2017 08:14 AM, Marc-André Lureau wrote:
> Use qvirtio_pci_device_find_slot() to avoid leaking the non-hp
> device. Add assert() to avoid further leaks in the future.
>
> Use qvirtio_pci_device_free() to correctly free QVirtioPCIDevice.
Yep, the hunk I mentioned in 28/30 probably belongs here, alongside the
other instances of this fix.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> tests/libqos/virtio-pci.c | 1 +
> tests/virtio-blk-test.c | 14 +++++++-------
> 2 files changed, 8 insertions(+), 7 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature