[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 03/28] tests: fix leaks in test-io-channel-command
From: |
Marc-André Lureau |
Subject: |
[Qemu-devel] [PULL 03/28] tests: fix leaks in test-io-channel-command |
Date: |
Wed, 1 Mar 2017 13:04:28 +0400 |
No need for strdup, fix leaks when socat is missing.
Spotted by ASAN.
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: "Daniel P. Berrange" <address@hidden>
Reviewed-by: Greg Kurz <address@hidden>
---
tests/test-io-channel-command.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/tests/test-io-channel-command.c b/tests/test-io-channel-command.c
index 1d1f461bed..46ce1ff01c 100644
--- a/tests/test-io-channel-command.c
+++ b/tests/test-io-channel-command.c
@@ -29,8 +29,8 @@ static void test_io_channel_command_fifo(bool async)
#define TEST_FIFO "tests/test-io-channel-command.fifo"
QIOChannel *src, *dst;
QIOChannelTest *test;
- char *srcfifo = g_strdup_printf("PIPE:%s,wronly", TEST_FIFO);
- char *dstfifo = g_strdup_printf("PIPE:%s,rdonly", TEST_FIFO);
+ const char *srcfifo = "PIPE:" TEST_FIFO ",wronly";
+ const char *dstfifo = "PIPE:" TEST_FIFO ",rdonly";
const char *srcargv[] = {
"/bin/socat", "-", srcfifo, NULL,
};
@@ -59,8 +59,6 @@ static void test_io_channel_command_fifo(bool async)
object_unref(OBJECT(src));
object_unref(OBJECT(dst));
- g_free(srcfifo);
- g_free(dstfifo);
unlink(TEST_FIFO);
}
--
2.12.0.rc2.3.gc93709801
- [Qemu-devel] [PULL 00/28] Leak patches, Marc-André Lureau, 2017/03/01
- [Qemu-devel] [PULL 01/28] qtest: fix a memory leak, Marc-André Lureau, 2017/03/01
- [Qemu-devel] [PULL 02/28] tests: fix qmp response leak, Marc-André Lureau, 2017/03/01
- [Qemu-devel] [PULL 03/28] tests: fix leaks in test-io-channel-command,
Marc-André Lureau <=
- [Qemu-devel] [PULL 04/28] timer: use an inline function for free, Marc-André Lureau, 2017/03/01
- [Qemu-devel] [PULL 05/28] glib-compat: add g_test_add_data_func_full fallback, Marc-André Lureau, 2017/03/01
- [Qemu-devel] [PULL 06/28] tests: fix ptimer leaks, Marc-André Lureau, 2017/03/01
- [Qemu-devel] [PULL 07/28] tests: fix endianness-test leaks, Marc-André Lureau, 2017/03/01
- [Qemu-devel] [PULL 08/28] tests: fix q35-test leaks, Marc-André Lureau, 2017/03/01
- [Qemu-devel] [PULL 09/28] tests: fix vhost-user-test leaks, Marc-André Lureau, 2017/03/01
- [Qemu-devel] [PULL 10/28] tests: fix ide-test leaks, Marc-André Lureau, 2017/03/01
- [Qemu-devel] [PULL 12/28] tests: fix bios-tables-test leak, Marc-André Lureau, 2017/03/01
- [Qemu-devel] [PULL 11/28] tests: fix hd-geo-test leaks, Marc-André Lureau, 2017/03/01
- [Qemu-devel] [PULL 13/28] tests: fix ipmi-kcs-test leak, Marc-André Lureau, 2017/03/01