Re: [Qemu-devel] [PATCH 0/6] target/s390x patches

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Type: series
Subject: [Qemu-devel] [PATCH 0/6] target/s390x patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
3a015db target/s390x: Use atomic operations for LOAD AND OP
8c4298d target/s390x: Use atomic operations for COMPARE SWAP
8f7d4ad target/s390x: Implement LOAD PAIR DISJOINT
de3b159 target/s390x: Diagnose specification exception for atomics
c687734 target/s390x: Implement LOAD PROGRAM PARAMETER
4e07a6d target/s390x: Implement STORE FACILITIES LIST EXTENDED

=== OUTPUT BEGIN ===
Checking PATCH 1/6: target/s390x: Implement STORE FACILITIES LIST EXTENDED...
ERROR: space prohibited between function name and open parenthesis '('
#71: FILE: target/s390x/misc_helper.c:682:
+    for (max_m1 = ARRAY_SIZE (buf) - 1; max_m1 > 0; --max_m1) {

total: 1 errors, 0 warnings, 90 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/6: target/s390x: Implement LOAD PROGRAM PARAMETER...
Checking PATCH 3/6: target/s390x: Diagnose specification exception for 
atomics...
Checking PATCH 4/6: target/s390x: Implement LOAD PAIR DISJOINT...
Checking PATCH 5/6: target/s390x: Use atomic operations for COMPARE SWAP...
Checking PATCH 6/6: target/s390x: Use atomic operations for LOAD AND OP...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden