[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/5] configure: detect presence of libxendevicem
From: |
Anthony PERARD |
Subject: |
Re: [Qemu-devel] [PATCH 4/5] configure: detect presence of libxendevicemodel |
Date: |
Thu, 2 Mar 2017 10:54:38 +0000 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Thu, Mar 02, 2017 at 09:06:43AM +0000, Paul Durrant wrote:
> > -----Original Message-----
> > From: Anthony PERARD [mailto:address@hidden
> > Sent: 01 March 2017 17:18
> > To: Paul Durrant <address@hidden>
> > Cc: address@hidden; address@hidden; Stefano
> > Stabellini <address@hidden>
> > Subject: Re: [PATCH 4/5] configure: detect presence of libxendevicemodel
> >
> > On Thu, Feb 23, 2017 at 02:53:54PM +0000, Paul Durrant wrote:
> > > This patch adds code in configure to set
> > CONFIG_XEN_CTRL_INTERFACE_VERSION
> > > to a new value of 490 if libxendevicemodel is present in the build
> > > environment.
> > >
> > > Signed-off-by: Paul Durrant <address@hidden>
> > > ---
> > > Cc: Stefano Stabellini <address@hidden>
> > > Cc: Anthony Perard <address@hidden>
> > > ---
> > > configure | 19 +++++++++++++++++++
> > > 1 file changed, 19 insertions(+)
> > >
> > > diff --git a/configure b/configure
> > > index 8e8f18d..fc1e12b 100755
> > > --- a/configure
> > > +++ b/configure
> > > @@ -1980,6 +1980,25 @@ EOF
> > > # Xen unstable
> > > elif
> > > cat > $TMPC <<EOF &&
> > > +#undef XC_WANT_COMPAT_DEVICEMODEL_API
> > > +#define __XEN_TOOLS__
> >
> > Isn't __XEN_TOOLS__ supposed to be reserved for some to tools inside
> > xen.git?
> >
> > Also it seems to be the only time this define is used in your patch
> > series.
> >
> No. QEMU falls under the definition of 'tools' as far as Xen goes and the
> hypercalls and xendevicemodel API are protected by that. The reason you don't
> see it elsewhere is that xenctrl.h defines it. (See
> http://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=tools/libxc/include/xenctrl.h;hb=HEAD#l27).
> I think that's a little underhand so I thought I'd make the new code in
> configure more transparent. I can change it to just include xenctrl.h before
> xendevicemodel.h if you'd prefer.
I guess that is fine with __XEN_TOOLS__.
You can add my
Reviewed-by: Anthony PERARD <address@hidden>
--
Anthony PERARD