Re: [Qemu-devel] [PATCH 0/2] misc aarch64 fixes for Windows

[Peter Maydell]

On 28 February 2017 at 22:22, Andrew Baumann
<address@hidden> wrote:
>> From: address@hidden [mailto:address@hidden
>> Sent: Tuesday, 28 February 2017 14:13
>>
>> Hi,
>>
>> This series failed build test on s390x host. Please find the details below.
> [..]
>> /var/tmp/patchew-tester-tmp-64adnjjr/src/target/arm/helper.c:931:23:
>> error: ‘pmreg_access_ccntr’ defined but not used [-Werror=unused-
>> function]
>>  static CPAccessResult pmreg_access_ccntr(CPUARMState *env,
>>                        ^~~~~~~~~~~~~~~~~~
>> /var/tmp/patchew-tester-tmp-64adnjjr/src/target/arm/helper.c:917:23:
>> error: ‘pmreg_access_selr’ defined but not used [-Werror=unused-function]
>>  static CPAccessResult pmreg_access_selr(CPUARMState *env,
>>                        ^~~~~~~~~~~~~~~~~
>
> Oops, these need to be protected with #ifndef CONFIG_USER_ONLY... will be 
> fixed in v2, but I'll wait for any other feedback.

I fixed up this nit applying the patch to target-arm.next.

thanks
-- PMM