[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 0/3] Introduce vhost-user-scsi and sample app
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH v4 0/3] Introduce vhost-user-scsi and sample application |
Date: |
Thu, 2 Mar 2017 17:17:21 +0000 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Thu, Mar 02, 2017 at 05:01:06PM +0000, Felipe Franciosi wrote:
> Hi Eric,
>
> Ping on this?
> http://lists.nongnu.org/archive/html/qemu-devel/2016-10/msg06169.html
[snip]
> CC contrib/ivshmem-client/main.o
>
> /var/tmp/patchew-tester-tmp-naxuy_ku/src/contrib/libvhost-user/libvhost-user.c:
> In function ‘vu_panic’:
>
> /var/tmp/patchew-tester-tmp-naxuy_ku/src/contrib/libvhost-user/libvhost-user.c:84:5:
> error: ignoring return value of ‘vasprintf’, declared with attribute
> warn_unused_result [-Werror=unused-result]
> (void)vasprintf(&buf, msg, ap);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
You can side-step the issue entirely by simply not using the vasprintf
function. Instead do 'buf = g_strdup_vprintf(msg, ap);' - glib does
abort-on-oom, so there's no error scenario you need to handle.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
- [Qemu-devel] [PATCH v4 0/3] Introduce vhost-user-scsi and sample application, Felipe Franciosi, 2017/03/02
- [Qemu-devel] [PATCH v4 2/3] vus: Introduce vhost-user-scsi host device, Felipe Franciosi, 2017/03/02
- [Qemu-devel] [PATCH v4 1/3] vhost-scsi: create a vhost-scsi-common abstraction, Felipe Franciosi, 2017/03/02
- [Qemu-devel] [PATCH v4 3/3] vus: Introduce a vhost-user-scsi sample application, Felipe Franciosi, 2017/03/02
- Re: [Qemu-devel] [PATCH v4 0/3] Introduce vhost-user-scsi and sample application, no-reply, 2017/03/02
- Re: [Qemu-devel] [PATCH v4 0/3] Introduce vhost-user-scsi and sample application, no-reply, 2017/03/02
- Re: [Qemu-devel] [PATCH v4 0/3] Introduce vhost-user-scsi and sample application, no-reply, 2017/03/02
- Re: [Qemu-devel] [PATCH v4 0/3] Introduce vhost-user-scsi and sample application, Felipe Franciosi, 2017/03/02
- Re: [Qemu-devel] [PATCH v4 0/3] Introduce vhost-user-scsi and sample application,
Daniel P. Berrange <=
- Re: [Qemu-devel] [PATCH v4 0/3] Introduce vhost-user-scsi and sample application, Felipe Franciosi, 2017/03/02
- Re: [Qemu-devel] [PATCH v4 0/3] Introduce vhost-user-scsi and sample application, Daniel P. Berrange, 2017/03/02
- Re: [Qemu-devel] [PATCH v4 0/3] Introduce vhost-user-scsi and sample application, Felipe Franciosi, 2017/03/02
- Re: [Qemu-devel] [PATCH v4 0/3] Introduce vhost-user-scsi and sample application, Paolo Bonzini, 2017/03/02
- Re: [Qemu-devel] [PATCH v4 0/3] Introduce vhost-user-scsi and sample application, Felipe Franciosi, 2017/03/02
- Re: [Qemu-devel] [PATCH v4 0/3] Introduce vhost-user-scsi and sample application, Eric Blake, 2017/03/02
Re: [Qemu-devel] [PATCH v4 0/3] Introduce vhost-user-scsi and sample application, Michael S. Tsirkin, 2017/03/29