[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 09/11] target/mips/op_helper: hold BQL before
|
From: |
Alex Bennée |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 09/11] target/mips/op_helper: hold BQL before calling cpu_mips_get_count |
|
Date: |
Fri, 03 Mar 2017 12:54:26 +0000 |
|
User-agent: |
mu4e 0.9.19; emacs 25.2.7 |
Yongbok Kim <address@hidden> writes:
> On 02/03/2017 19:53, Alex Bennée wrote:
>> We should hold the BQL before we transition to HW emulation. This is
>> because all HW emulation needs to be serialised under MTTCG
>> conditions. This is picked up by asserts that fire when
>> cpu_mips_get_count triggers and IRQ.
>>
>> Reported-by: Yongbok Kim <address@hidden>
>> Signed-off-by: Alex Bennée <address@hidden>
>
> Hi Alex,
>
> Thanks for this but it is required to have few more locks.
> I will send the patch shortly. Please merge it into your patchset.
Thanks, I'll look out for it.
Have you been tracking the MTTCG work? Once the BQL issues are sorted as
long as atomics, barriers and tlb flushes are updated you can turn on
mttcg by default.
>
> Regards,
> Yongbok
--
Alex Bennée