[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/15] sheepdog: Fix error handling sd_create()
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 03/15] sheepdog: Fix error handling sd_create() |
Date: |
Fri, 3 Mar 2017 14:13:25 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 02.03.2017 um 22:43 hat Markus Armbruster geschrieben:
> As a bdrv_create() method, sd_create() must set an error and return
> negative errno on failure. It prints the error instead of setting it
> when connect_to_sdog() fails. Fix that.
>
> While there, return the value of connect_to_sdog() like we do
> elsewhere, instead of -EIO. No functional change, as
> connect_to_sdog() returns no other error code.
>
> Many more suspicious uses of error_report() and error_report_err()
> remain in other functions. Left for another day.
>
> Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
- [Qemu-devel] [PATCH 00/15] block: A bunch of fixes for Sheepdog and Gluster, Markus Armbruster, 2017/03/02
- [Qemu-devel] [PATCH 11/15] gluster: Don't duplicate qapi-util.c's qapi_enum_parse(), Markus Armbruster, 2017/03/02
- [Qemu-devel] [PATCH 03/15] sheepdog: Fix error handling sd_create(), Markus Armbruster, 2017/03/02
- [Qemu-devel] [PATCH 10/15] gluster: Drop assumptions on SocketTransport names, Markus Armbruster, 2017/03/02
- [Qemu-devel] [PATCH 04/15] sheepdog: Mark sd_snapshot_delete() lossage FIXME, Markus Armbruster, 2017/03/02
- [Qemu-devel] [PATCH 01/15] sheepdog: Defuse time bomb in sd_open() error handling, Markus Armbruster, 2017/03/02
- [Qemu-devel] [PATCH 06/15] sheepdog: Don't truncate long VDI name in _open(), _create(), Markus Armbruster, 2017/03/02