Re: [Qemu-devel] [PATCH for-2.9 0/6] disas: Fix various coverity nits

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Type: series
Subject: [Qemu-devel] [PATCH for-2.9 0/6] disas: Fix various coverity nits

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
2b4422e disas/arm: Avoid unintended sign extension
6f6e588 disas/cris: Avoid unintended sign extension
5213cbe disas/microblaze: Avoid unintended sign extension
661cc81 disas/m68k: Avoid unintended sign extension in get_field()
dab63cb disas/i386: Avoid NULL pointer dereference in error case
8a3705f disas/hppa: Remove dead code

=== OUTPUT BEGIN ===
Checking PATCH 1/6: disas/hppa: Remove dead code...
Checking PATCH 2/6: disas/i386: Avoid NULL pointer dereference in error case...
ERROR: suspect code indent for conditional statements (6, 10)
#22: FILE: disas/i386.c:4046:
+      if (dp->name != NULL && putop (dp->name, sizeflag) == 0)
         {

ERROR: space prohibited between function name and open parenthesis '('
#22: FILE: disas/i386.c:4046:
+      if (dp->name != NULL && putop (dp->name, sizeflag) == 0)

total: 2 errors, 0 warnings, 8 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/6: disas/m68k: Avoid unintended sign extension in 
get_field()...
ERROR: code indent should never use tabs
#27: FILE: disas/m68k.c:4688:
+^I  (unsigned long)(*(data + cur_byte)$

ERROR: code indent should never use tabs
#28: FILE: disas/m68k.c:4689:
+^I^I^I  & ((1 << (len - cur_bitshift)) - 1))$

ERROR: code indent should never use tabs
#32: FILE: disas/m68k.c:4692:
+^Iresult |= (unsigned long)*(data + cur_byte) << cur_bitshift;$

total: 3 errors, 0 warnings, 13 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 4/6: disas/microblaze: Avoid unintended sign extension...
Checking PATCH 5/6: disas/cris: Avoid unintended sign extension...
ERROR: code indent should never use tabs
#27: FILE: disas/cris.c:2012:
+^I  uint32_t number$

ERROR: code indent should never use tabs
#36: FILE: disas/cris.c:2204:
+^I^I^Iuint32_t number$

total: 2 errors, 0 warnings, 16 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 6/6: disas/arm: Avoid unintended sign extension...
ERROR: code indent should never use tabs
#27: FILE: disas/arm.c:3904:
+^Igiven = (b[0]) | (b[1] << 8) | (b[2] << 16) | ((unsigned)b[3] << 24);$

ERROR: code indent should never use tabs
#30: FILE: disas/arm.c:3906:
+^Igiven = (b[3]) | (b[2] << 8) | (b[1] << 16) | ((unsigned)b[0] << 24);$

total: 2 errors, 0 warnings, 11 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden