[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] 9pfs: fix bogus fd check in local_remove()
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] 9pfs: fix bogus fd check in local_remove() |
Date: |
Fri, 3 Mar 2017 10:33:50 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 03/03/2017 10:17 AM, Greg Kurz wrote:
> This was spotted by Coverity as a fd leak. This is certainly true, but also
> local_remove() would always return without doing anything, unless the fd is
> zero, which is very unlikely.
>
> (Coverity issue CID1371732)
>
> Signed-off-by: Greg Kurz <address@hidden>
> ---
> hw/9pfs/9p-local.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Eric Blake <address@hidden>
> diff --git a/hw/9pfs/9p-local.c b/hw/9pfs/9p-local.c
> index f22a3c3654db..5db7104334d6 100644
> --- a/hw/9pfs/9p-local.c
> +++ b/hw/9pfs/9p-local.c
> @@ -1008,7 +1008,7 @@ static int local_remove(FsContext *ctx, const char
> *path)
> int err = -1;
>
> dirfd = local_opendir_nofollow(ctx, dirpath);
> - if (dirfd) {
> + if (dirfd == -1) {
> goto out;
> }
>
>
>
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature