[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] 9pfs: fail local_statfs() earlier
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH] 9pfs: fail local_statfs() earlier |
Date: |
Fri, 3 Mar 2017 18:13:29 +0000 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Fri, Mar 03, 2017 at 07:03:47PM +0100, Greg Kurz wrote:
> If we cannot open the given path, we can return right away instead of
> passing -1 to fstatfs() and close(). This will make Coverity happy.
>
> (Coverity issue CID1371729)
>
> Signed-off-by: Greg Kurz <address@hidden>
> ---
> hw/9pfs/9p-local.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/hw/9pfs/9p-local.c b/hw/9pfs/9p-local.c
> index fe930300445a..ea9a1ced0394 100644
> --- a/hw/9pfs/9p-local.c
> +++ b/hw/9pfs/9p-local.c
> @@ -1053,6 +1053,9 @@ static int local_statfs(FsContext *s, V9fsPath
> *fs_path, struct statfs *stbuf)
> int fd, ret;
>
> fd = local_open_nofollow(s, fs_path->data, O_RDONLY, 0);
> + if (fd == -1) {
> + return -1;
> + }
> ret = fstatfs(fd, stbuf);
> close_preserve_errno(fd);
> return ret;
Reviewed-by: Daniel P. berrange <address@hidden>
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|