qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [Qemu-trivial] [PATCH] util: Use g_malloc/g_free in env


From: no-reply
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] util: Use g_malloc/g_free in envlist.c
Date: Sat, 4 Mar 2017 06:19:57 -0800 (PST)

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [Qemu-trivial] [PATCH] util: Use g_malloc/g_free in 
envlist.c
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
ffeb4a7 util: Use g_malloc/g_free in envlist.c

=== OUTPUT BEGIN ===
Checking PATCH 1/1: util: Use g_malloc/g_free in envlist.c...
ERROR: code indent should never use tabs
#100: FILE: util/envlist.c:27:
+^Ienvlist = g_malloc(sizeof (*envlist));$

ERROR: space prohibited between function name and open parenthesis '('
#100: FILE: util/envlist.c:27:
+       envlist = g_malloc(sizeof (*envlist));

ERROR: code indent should never use tabs
#109: FILE: util/envlist.c:50:
+^I^Ig_free(entry);$

ERROR: code indent should never use tabs
#112: FILE: util/envlist.c:52:
+^Ig_free(envlist);$

ERROR: code indent should never use tabs
#121: FILE: util/envlist.c:157:
+^I^Ig_free(entry);$

ERROR: code indent should never use tabs
#128: FILE: util/envlist.c:162:
+^Ientry = g_malloc(sizeof (*entry));$

ERROR: space prohibited between function name and open parenthesis '('
#128: FILE: util/envlist.c:162:
+       entry = g_malloc(sizeof (*entry));

ERROR: code indent should never use tabs
#131: FILE: util/envlist.c:164:
+^I^Ig_free(entry);$

ERROR: code indent should never use tabs
#140: FILE: util/envlist.c:202:
+^I^Ig_free(entry);$

ERROR: code indent should never use tabs
#168: FILE: util/envlist.c:225:
+^Ipenv = env = g_malloc((envlist->el_count + 1) * sizeof (char *));$

ERROR: space prohibited between function name and open parenthesis '('
#168: FILE: util/envlist.c:225:
+       penv = env = g_malloc((envlist->el_count + 1) * sizeof (char *));

total: 11 errors, 0 warnings, 130 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]