qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] 9pfs: don't use AT_EMPTY_PATH in local_set_cred


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH] 9pfs: don't use AT_EMPTY_PATH in local_set_cred_passthrough()
Date: Sat, 4 Mar 2017 09:16:34 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0

On 03/04/2017 04:54 AM, Greg Kurz wrote:
> The name argument can never be an empty string, and dirfd always point to
> the containing directory of the file name. AT_EMPTY_PATH is hence useless
> here. Also it breaks build with glibc version 2.13 and older.
> 
> It is actually an oversight of a previous tentative patch to implement this
> function. We can safely drop it.
> 
> Reported-by: Mark Cave-Ayland <address@hidden>
> Signed-off-by: Greg Kurz <address@hidden>
> ---
>  hw/9pfs/9p-local.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]