[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v2 10/24] qjson: Abort earlier on qobject_from_jsonf(
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PULL v2 10/24] qjson: Abort earlier on qobject_from_jsonf() misuse |
Date: |
Mon, 6 Mar 2017 15:11:41 +0100 |
Ignoring errors first, then asserting success is suboptimal. Pass
&error_abort instead, so we abort earlier, and hopefully get more
useful clues on what's wrong.
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
Message-Id: <address@hidden>
---
qobject/qjson.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qobject/qjson.c b/qobject/qjson.c
index 339c9f7..c98d6a7 100644
--- a/qobject/qjson.c
+++ b/qobject/qjson.c
@@ -65,7 +65,7 @@ QObject *qobject_from_jsonf(const char *string, ...)
va_list ap;
va_start(ap, string);
- obj = qobject_from_jsonv(string, &ap, NULL);
+ obj = qobject_from_jsonv(string, &ap, &error_abort);
va_end(ap);
assert(obj != NULL);
--
2.7.4
- [Qemu-devel] [PULL v2 00/24] block: Command line option -blockdev, Markus Armbruster, 2017/03/06
- [Qemu-devel] [PULL v2 01/24] test-qemu-opts: Cover qemu_opts_parse() of "no", Markus Armbruster, 2017/03/06
- [Qemu-devel] [PULL v2 16/24] monitor: Assert qmp_schema_json[] is sane, Markus Armbruster, 2017/03/06
- [Qemu-devel] [PULL v2 13/24] block: More detailed syntax error reporting for JSON filenames, Markus Armbruster, 2017/03/06
- [Qemu-devel] [PULL v2 08/24] qobject: Propagate parse errors through qobject_from_jsonv(), Markus Armbruster, 2017/03/06
- [Qemu-devel] [PULL v2 06/24] qapi: Factor out common part of qobject input visitor creation, Markus Armbruster, 2017/03/06
- [Qemu-devel] [PULL v2 18/24] qapi: New parse_qapi_name(), Markus Armbruster, 2017/03/06
- [Qemu-devel] [PULL v2 19/24] keyval: Restrict key components to valid QAPI names, Markus Armbruster, 2017/03/06
- [Qemu-devel] [PULL v2 10/24] qjson: Abort earlier on qobject_from_jsonf() misuse,
Markus Armbruster <=
- [Qemu-devel] [PULL v2 09/24] libqtest: Fix qmp() & friends to abort on JSON parse errors, Markus Armbruster, 2017/03/06
- [Qemu-devel] [PULL v2 15/24] test-visitor-serialization: Pass &error_abort to qobject_from_json(), Markus Armbruster, 2017/03/06
- [Qemu-devel] [PULL v2 12/24] qobject: Propagate parse errors through qobject_from_json(), Markus Armbruster, 2017/03/06
- [Qemu-devel] [PULL v2 11/24] test-qobject-input-visitor: Abort earlier on bad test input, Markus Armbruster, 2017/03/06
- [Qemu-devel] [PULL v2 22/24] qapi: Improve how keyval input visitor reports unexpected dicts, Markus Armbruster, 2017/03/06
- [Qemu-devel] [PULL v2 05/24] test-keyval: Cover use with qobject input visitor, Markus Armbruster, 2017/03/06
- [Qemu-devel] [PULL v2 04/24] qapi: qobject input visitor variant for use with keyval_parse(), Markus Armbruster, 2017/03/06
- [Qemu-devel] [PULL v2 17/24] test-qapi-util: New, covering qapi/qapi-util.c, Markus Armbruster, 2017/03/06
- [Qemu-devel] [PULL v2 21/24] block: Initial implementation of -blockdev, Markus Armbruster, 2017/03/06
- [Qemu-devel] [PULL v2 24/24] keyval: Support lists, Markus Armbruster, 2017/03/06