Re: [Qemu-devel] [PATCH 0/2] sm501: drop obsolete code

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH 0/2] sm501: drop obsolete code
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
6c01c06 sm501: drop sm501_template.h
1eac5db sm501: drop support for anything but 32bpp

=== OUTPUT BEGIN ===
Checking PATCH 1/2: sm501: drop support for anything but 32bpp...
ERROR: code indent should never use tabs
#120: FILE: hw/display/sm501.c:1204:
+^Idraw_line = draw_line8_32;$

ERROR: code indent should never use tabs
#125: FILE: hw/display/sm501.c:1208:
+^Idraw_line = draw_line16_32;$

ERROR: code indent should never use tabs
#130: FILE: hw/display/sm501.c:1212:
+^Idraw_line = draw_line32_32;$

total: 3 errors, 0 warnings, 122 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/2: sm501: drop sm501_template.h...
ERROR: space prohibited before that '++' (ctx:WxO)
#35: FILE: hw/display/sm501.c:1183:
+        s ++;
           ^

ERROR: "foo * bar" should be "foo *bar"
#84: FILE: hw/display/sm501.c:1230:
+static void draw_hwc_line(SM501State * s, int crt,

ERROR: "foo * bar" should be "foo *bar"
#85: FILE: hw/display/sm501.c:1231:
+                          uint8_t * palette, int c_y, uint8_t *d, int width)

ERROR: code indent should never use tabs
#138: FILE: hw/display/sm501.c:1293:
+^Idraw_line = draw_line8;$

ERROR: code indent should never use tabs
#143: FILE: hw/display/sm501.c:1297:
+^Idraw_line = draw_line16;$

ERROR: code indent should never use tabs
#148: FILE: hw/display/sm501.c:1301:
+^Idraw_line = draw_line32;$

ERROR: code indent should never use tabs
#167: FILE: hw/display/sm501.c:1335:
+^Iint update_hwc = is_hwc_enabled(s, 1) && within_hwc_y_range(s, y, 1);$

total: 7 errors, 0 warnings, 147 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden