Re: [Qemu-devel] [PATCH v3 03/11] cpus.c: add additional error_report when !TARGET_SUPPORT_MTTCG

[Philippe Mathieu-Daudé]

On 03/07/2017 12:50 PM, Alex Bennée wrote:
> While we may fail the memory ordering check later that can be
> confusing. So in cases where TARGET_SUPPORT_MTTCG has yet to be
> defined we should say so specifically.
>
> Signed-off-by: Alex Bennée <address@hidden>
> Reviewed-by: Richard Henderson <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

> ---
>  cpus.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/cpus.c b/cpus.c
> index 6a817fec13..69e21858b8 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -202,6 +202,10 @@ void qemu_tcg_configure(QemuOpts *opts, Error **errp)
>              } else if (use_icount) {
>                  error_setg(errp, "No MTTCG when icount is enabled");
>              } else {
> +#ifndef TARGET_SUPPORT_MTTCG
> +                error_report("Guest not yet converted to MTTCG - "
> +                             "you may get unexpected results");
> +#endif
>                  if (!check_tcg_memory_orders_compatible()) {
>                      error_report("Guest expects a stronger memory ordering "
>                                   "than the host provides");