[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 03/11] cpus.c: add additional error_report when !TARG
From: |
Alex Bennée |
Subject: |
[Qemu-devel] [PULL 03/11] cpus.c: add additional error_report when !TARGET_SUPPORT_MTTCG |
Date: |
Thu, 9 Mar 2017 11:17:06 +0000 |
While we may fail the memory ordering check later that can be
confusing. So in cases where TARGET_SUPPORT_MTTCG has yet to be
defined we should say so specifically.
Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
---
cpus.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/cpus.c b/cpus.c
index 6a817fec13..69e21858b8 100644
--- a/cpus.c
+++ b/cpus.c
@@ -202,6 +202,10 @@ void qemu_tcg_configure(QemuOpts *opts, Error **errp)
} else if (use_icount) {
error_setg(errp, "No MTTCG when icount is enabled");
} else {
+#ifndef TARGET_SUPPORT_MTTCG
+ error_report("Guest not yet converted to MTTCG - "
+ "you may get unexpected results");
+#endif
if (!check_tcg_memory_orders_compatible()) {
error_report("Guest expects a stronger memory ordering "
"than the host provides");
--
2.11.0
- [Qemu-devel] [PULL 00/11] MTTCG Fix-ups for 2.9, Alex Bennée, 2017/03/09
- [Qemu-devel] [PULL 02/11] target/i386/cpu.h: declare TCG_GUEST_DEFAULT_MO, Alex Bennée, 2017/03/09
- [Qemu-devel] [PULL 01/11] vl/cpus: be smarter with icount and MTTCG, Alex Bennée, 2017/03/09
- [Qemu-devel] [PULL 03/11] cpus.c: add additional error_report when !TARGET_SUPPORT_MTTCG,
Alex Bennée <=
- [Qemu-devel] [PULL 04/11] sparc/sparc64: grab BQL before calling cpu_check_irqs, Alex Bennée, 2017/03/09
- [Qemu-devel] [PULL 07/11] translate-all: exit cpu_restore_state early if translating, Alex Bennée, 2017/03/09
- [Qemu-devel] [PULL 05/11] s390x/misc_helper.c: wrap IO instructions in BQL, Alex Bennée, 2017/03/09
- [Qemu-devel] [PULL 06/11] target/xtensa: hold BQL for interrupt processing, Alex Bennée, 2017/03/09
- [Qemu-devel] [PULL 10/11] target/arm/helper: make it clear the EC field is also in hex, Alex Bennée, 2017/03/09
- [Qemu-devel] [PULL 09/11] target-i386: defer VMEXIT to do_interrupt, Alex Bennée, 2017/03/09
- [Qemu-devel] [PULL 08/11] target/mips: hold BQL for timer interrupts, Alex Bennée, 2017/03/09
- [Qemu-devel] [PULL 11/11] hw/intc/arm_gic: modernise the DPRINTF, Alex Bennée, 2017/03/09
- Re: [Qemu-devel] [PULL 00/11] MTTCG Fix-ups for 2.9, Peter Maydell, 2017/03/13