Re: [Qemu-devel] [PATCH v2] memory_region: Fix name comments

[Dr. David Alan Gilbert]

* Paolo Bonzini (address@hidden) wrote:
> 
> 
> On 09/03/2017 17:13, Dr. David Alan Gilbert wrote:
> >>> + * @name: Region name, becomes part of RAMBlock name used in migration 
> >>> stream
> >>> + *        must be unique within any device
> >>>   * @size: size of the region; any subregions beyond this size will be 
> >>> clipped
> >>>   */
> >>>  void memory_region_init(MemoryRegion *mr,
> >>>                          struct Object *owner,
> >>>                          const char *name,
> >>>                          uint64_t size);
> >> This one should not be necessary I guess?
> > Why? It's not static so something else could be calling it for
> > any use.
> 
> But why would the name end up in a RAMBlock?

It is used by all of the _ram specific functions, so it seemed worth
including the comment.

(I also see it's used in some of the boards but I don't understand
why - e.g. hw/ppc/ppc405_boards.c calls it on something that looks
like RAM.  Although perhaps that's related to the 'fix this' above it)

Dave

> Paolo
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK