[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH fix for-2.9] target/ppc: fix cpu_ov setting for 32-b
From: |
Nikunj A Dadhania |
Subject: |
[Qemu-devel] [PATCH fix for-2.9] target/ppc: fix cpu_ov setting for 32-bit |
Date: |
Mon, 13 Mar 2017 15:01:04 +0530 |
A bug was introduced in following commit:
dc0ad84 target/ppc: update overflow flags for add/sub
As for 32-bit ppc target extracting bit 63 for overflow is not correct.
Made it dependent on TARGET_LOG_BITS. This had broken booting MacOS
9.2.1 image
Reported-by: Mark Cave-Ayland <address@hidden>
Signed-off-by: Nikunj A Dadhania <address@hidden>
---
target/ppc/translate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/ppc/translate.c b/target/ppc/translate.c
index b6abc60..f40b5a1 100644
--- a/target/ppc/translate.c
+++ b/target/ppc/translate.c
@@ -818,7 +818,7 @@ static inline void gen_op_arith_compute_ov(DisasContext
*ctx, TCGv arg0,
if (is_isa300(ctx)) {
tcg_gen_extract_tl(cpu_ov32, cpu_ov, 31, 1);
}
- tcg_gen_extract_tl(cpu_ov, cpu_ov, 63, 1);
+ tcg_gen_extract_tl(cpu_ov, cpu_ov, TARGET_LONG_BITS - 1, 1);
}
tcg_gen_or_tl(cpu_so, cpu_so, cpu_ov);
}
--
2.9.3
- [Qemu-devel] [PATCH fix for-2.9] target/ppc: fix cpu_ov setting for 32-bit,
Nikunj A Dadhania <=