[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/16] migration: Create x-multifd-threads param
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH 06/16] migration: Create x-multifd-threads parameter |
Date: |
Mon, 13 Mar 2017 16:37:44 +0000 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Mon, Mar 13, 2017 at 01:44:24PM +0100, Juan Quintela wrote:
> Indicates the number of threads that we would create. By default we
> create 2 threads.
>
> Signed-off-by: Juan Quintela <address@hidden>
> Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index d21934b..b7cb26d 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -985,13 +985,17 @@
> # @x-checkpoint-delay: The delay time (in ms) between two COLO checkpoints in
> # periodic mode. (Since 2.8)
> #
> +# @x-multifd-threads: Number of threads used to migrate data in parallel
> +# The default value is 2 (since 2.9)
> +#
> # Since: 2.4
> ##
> { 'enum': 'MigrationParameter',
> 'data': ['compress-level', 'compress-threads', 'decompress-threads',
> 'cpu-throttle-initial', 'cpu-throttle-increment',
> 'tls-creds', 'tls-hostname', 'max-bandwidth',
> - 'downtime-limit', 'x-checkpoint-delay' ] }
> + 'downtime-limit', 'x-checkpoint-delay',
> + 'x-multifd-threads'] }
>
> ##
> # @migrate-set-parameters:
> @@ -1054,6 +1058,10 @@
> #
> # @x-checkpoint-delay: the delay time between two COLO checkpoints. (Since
> 2.8)
> #
> +#
> +# @x-multifd-threads: Number of threads used to migrate data in parallel
> +# The default value is 2 (since 2.9)
> +#
Presumably, the number of threads is the same as the number of sockets
opened ? It is probably useful to make it explicit that increasing
threads also causes increased number of TCP sockets to be opened.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
- [Qemu-devel] [PATCH 02/16] qio: create new qio_channel_read_all, (continued)
[Qemu-devel] [PATCH 08/16] migration: Create multifd migration threads, Juan Quintela, 2017/03/13
[Qemu-devel] [PATCH 06/16] migration: Create x-multifd-threads parameter, Juan Quintela, 2017/03/13
- Re: [Qemu-devel] [PATCH 06/16] migration: Create x-multifd-threads parameter,
Daniel P. Berrange <=
[Qemu-devel] [PATCH 09/16] migration: Start of multiple fd work, Juan Quintela, 2017/03/13
[Qemu-devel] [PATCH 10/16] migration: Create ram_multifd_page, Juan Quintela, 2017/03/13
[Qemu-devel] [PATCH 11/16] migration: Really use multiple pages at a time, Juan Quintela, 2017/03/13
[Qemu-devel] [PATCH 12/16] migration: Send the fd number which we are going to use for this page, Juan Quintela, 2017/03/13
[Qemu-devel] [PATCH 14/16] migration: Test new fd infrastructure, Juan Quintela, 2017/03/13