qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH v2 11/30] trace: Fix parameter types in hw/audio


From: Eric Blake
Subject: [Qemu-devel] [PATCH v2 11/30] trace: Fix parameter types in hw/audio
Date: Mon, 13 Mar 2017 14:55:28 -0500

An upcoming patch will let the compiler warn us when we are silently
losing precision in traces; update the trace definitions to pass
through the full value at the callsite.

Signed-off-by: Eric Blake <address@hidden>
---
 hw/audio/trace-events | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/hw/audio/trace-events b/hw/audio/trace-events
index 3210386..ea5f0c2 100644
--- a/hw/audio/trace-events
+++ b/hw/audio/trace-events
@@ -3,12 +3,12 @@
 # hw/audio/cs4231.c
 cs4231_mem_readl_dreg(uint32_t reg, uint32_t ret) "read dreg %d: 0x%02x"
 cs4231_mem_readl_reg(uint32_t reg, uint32_t ret) "read reg %d: 0x%08x"
-cs4231_mem_writel_reg(uint32_t reg, uint32_t old, uint32_t val) "write reg %d: 
0x%08x -> 0x%08x"
-cs4231_mem_writel_dreg(uint32_t reg, uint32_t old, uint32_t val) "write dreg 
%d: 0x%02x -> 0x%02x"
+cs4231_mem_writel_reg(uint32_t reg, uint32_t old, uint64_t val) "write reg %d: 
0x%08x -> 0x%08" PRIx64
+cs4231_mem_writel_dreg(uint32_t reg, uint32_t old, uint64_t val) "write dreg 
%d: 0x%02x -> 0x%02" PRIx64

 # hw/audio/milkymist-ac97.c
-milkymist_ac97_memory_read(uint32_t addr, uint32_t value) "addr %08x value 
%08x"
-milkymist_ac97_memory_write(uint32_t addr, uint32_t value) "addr %08x value 
%08x"
+milkymist_ac97_memory_read(hwaddr addr, uint32_t value) "addr %08" HWADDR_PRIx 
" value %08x"
+milkymist_ac97_memory_write(hwaddr addr, uint64_t value) "addr %08" 
HWADDR_PRIx " value %08" PRIx64
 milkymist_ac97_pulse_irq_crrequest(void) "Pulse IRQ CR request"
 milkymist_ac97_pulse_irq_crreply(void) "Pulse IRQ CR reply"
 milkymist_ac97_pulse_irq_dmaw(void) "Pulse IRQ DMA write"
-- 
2.9.3




reply via email to

[Prev in Thread] Current Thread [Next in Thread]