[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 14/30] trace: Fix parameter types in hw/display
From: |
Eric Blake |
Subject: |
[Qemu-devel] [PATCH v2 14/30] trace: Fix parameter types in hw/display |
Date: |
Mon, 13 Mar 2017 14:55:31 -0500 |
An upcoming patch will let the compiler warn us when we are silently
losing precision in traces; update the trace definitions to pass
through the full value at the callsite.
Signed-off-by: Eric Blake <address@hidden>
---
hw/display/trace-events | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/hw/display/trace-events b/hw/display/trace-events
index 3e896d2..515767d 100644
--- a/hw/display/trace-events
+++ b/hw/display/trace-events
@@ -10,17 +10,17 @@ xenfb_input_connected(void *xendev, int abs_pointer_wanted)
"%p abs %d"
# hw/display/g364fb.c
g364fb_read(uint64_t addr, uint32_t val) "read addr=0x%"PRIx64": 0x%x"
-g364fb_write(uint64_t addr, uint32_t new) "write addr=0x%"PRIx64": 0x%x"
+g364fb_write(uint64_t addr, uint64_t new) "write addr=0x%"PRIx64": 0x%" PRIx64
# hw/display/milkymist-tmu2.c
-milkymist_tmu2_memory_read(uint32_t addr, uint32_t value) "addr %08x value
%08x"
-milkymist_tmu2_memory_write(uint32_t addr, uint32_t value) "addr %08x value
%08x"
+milkymist_tmu2_memory_read(hwaddr addr, uint32_t value) "addr %08" HWADDR_PRIx
" value %08x"
+milkymist_tmu2_memory_write(hwaddr addr, uint64_t value) "addr %08"
HWADDR_PRIx " value %08" PRIx64
milkymist_tmu2_start(void) "Start TMU"
milkymist_tmu2_pulse_irq(void) "Pulse IRQ"
# hw/display/milkymist-vgafb.c
-milkymist_vgafb_memory_read(uint32_t addr, uint32_t value) "addr %08x value
%08x"
-milkymist_vgafb_memory_write(uint32_t addr, uint32_t value) "addr %08x value
%08x"
+milkymist_vgafb_memory_read(hwaddr addr, uint32_t value) "addr %08"
HWADDR_PRIx " value %08x"
+milkymist_vgafb_memory_write(hwaddr addr, uint64_t value) "addr %08"
HWADDR_PRIx " value %08" PRIx64
# hw/display/vmware_vga.c
vmware_value_read(uint32_t index, uint32_t value) "index %d, value 0x%x"
@@ -61,11 +61,11 @@ qxl_create_guest_primary_rest(int qid, int32_t stride,
uint32_t type, uint32_t f
qxl_destroy_primary(int qid) "%d"
qxl_enter_vga_mode(int qid) "%d"
qxl_exit_vga_mode(int qid) "%d"
-qxl_hard_reset(int qid, int64_t loadvm) "%d loadvm=%"PRId64
+qxl_hard_reset(int qid, int loadvm) "%d loadvm=%d"
qxl_interface_async_complete_io(int qid, uint32_t current_async, void *cookie)
"%d current=%d cookie=%p"
qxl_interface_attach_worker(int qid) "%d"
qxl_interface_get_init_info(int qid) "%d"
-qxl_interface_set_compression_level(int qid, int64_t level) "%d %"PRId64
+qxl_interface_set_compression_level(int qid, int level) "%d %d"
qxl_interface_update_area_complete(int qid, uint32_t surface_id, uint32_t
dirty_left, uint32_t dirty_right, uint32_t dirty_top, uint32_t dirty_bottom)
"%d surface=%d [%d,%d,%d,%d]"
qxl_interface_update_area_complete_rest(int qid, uint32_t num_updated_rects)
"%d #=%d"
qxl_interface_update_area_complete_overflow(int qid, int max) "%d max=%d"
@@ -112,7 +112,7 @@ qxl_interrupt_client_monitors_config(int qid, int
num_heads, void *heads) "%d %d
qxl_client_monitors_config_unsupported_by_guest(int qid, uint32_t int_mask,
void *client_monitors_config) "%d %X %p"
qxl_client_monitors_config_unsupported_by_device(int qid, int revision) "%d
revision=%d"
qxl_client_monitors_config_capped(int qid, int requested, int limit) "%d %d %d"
-qxl_client_monitors_config_crc(int qid, unsigned size, uint32_t crc32) "%d %u
%u"
+qxl_client_monitors_config_crc(int qid, size_t size, uint32_t crc32) "%d %zu
%u"
qxl_set_client_capabilities_unsupported_by_revision(int qid, int revision) "%d
revision=%d"
# hw/display/qxl-render.c
@@ -127,7 +127,7 @@ vga_vbe_read(uint32_t index, uint32_t val) "index 0x%x, val
0x%x"
vga_vbe_write(uint32_t index, uint32_t val) "index 0x%x, val 0x%x"
# hw/display/cirrus_vga.c
-vga_cirrus_read_io(uint32_t addr, uint32_t val) "addr 0x%x, val 0x%x"
-vga_cirrus_write_io(uint32_t addr, uint32_t val) "addr 0x%x, val 0x%x"
+vga_cirrus_read_io(hwaddr addr, int val) "addr 0x%" HWADDR_PRIx ", val 0x%x"
+vga_cirrus_write_io(hwaddr addr, uint64_t val) "addr 0x%" HWADDR_PRIx ", val
0x%" PRIx64
vga_cirrus_read_blt(uint32_t offset, uint32_t val) "offset 0x%x, val 0x%x"
vga_cirrus_write_blt(uint32_t offset, uint32_t val) "offset 0x%x, val 0x%x"
--
2.9.3
- [Qemu-devel] [PATCH v2 07/30] trace: Fix parameter types in ui, (continued)
- [Qemu-devel] [PATCH v2 07/30] trace: Fix parameter types in ui, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 08/30] trace: Fix parameter types in top level, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 10/30] trace: Fix parameter types in hw/acpi, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 13/30] trace: Fix parameter types in hw/char, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 16/30] trace: Fix parameter types in hw/i386, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 11/30] trace: Fix parameter types in hw/audio, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 09/30] trace: Fix parameter types in linux-user, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 12/30] trace: Fix parameter types in hw/block, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 15/30] trace: Fix parameter types in hw/dma, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 17/30] trace: Fix parameter types in hw/input, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 14/30] trace: Fix parameter types in hw/display,
Eric Blake <=
- [Qemu-devel] [PATCH v2 18/30] trace: Fix parameter types in hw/intc, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 20/30] trace: Fix parameter types in hw/misc, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 21/30] trace: Fix parameter types in hw/net, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 19/30] trace: Fix parameter types in hw/isa, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 22/30] trace: Fix parameter types in hw/nvram, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 24/30] trace: Fix parameter types in hw/sd, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 26/30] trace: Fix parameter types in hw/timer, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 23/30] trace: Fix parameter types in hw/ppc, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 28/30] trace: Fix parameter types in hw/vfio, Eric Blake, 2017/03/13