[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] vnc: fix reverse mode
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH] vnc: fix reverse mode |
Date: |
Tue, 14 Mar 2017 10:24:05 +0000 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Tue, Mar 14, 2017 at 09:26:58AM +0100, Gerd Hoffmann wrote:
> vnc server in reverse mode (qemu -vnc localhost:$nr,reverse) interprets
> $nr as display number (i.e. with 5900 offset) in recent qemu versions.
> Historical and documented behavior is interpreting $nr as port number
> though. So we should bring code and documentation in line.
>
> Given that default listening port for viewers is 5500 the 5900 offset is
> pretty inconvinient, because it is simply impossible to connect to port
> 5500. So, lets fix the code not the docs.
>
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> ui/vnc.c | 17 ++++++++++-------
> 1 file changed, 10 insertions(+), 7 deletions(-)
Reviewed-by: Daniel P. Berrange <address@hidden>
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|