qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 00/16] Multifd v4


From: Daniel P. Berrange
Subject: Re: [Qemu-devel] [PATCH 00/16] Multifd v4
Date: Tue, 14 Mar 2017 11:47:04 +0000
User-agent: Mutt/1.7.1 (2016-10-04)

On Tue, Mar 14, 2017 at 10:21:43AM +0000, Dr. David Alan Gilbert wrote:
> * Juan Quintela (address@hidden) wrote:
> > Hi
> > 
> > This is the 4th version of multifd. Changes:
> > - XBZRLE don't need to be checked for
> > - Documentation and defaults are consistent
> > - split socketArgs
> > - use iovec instead of creating something similar.
> > - We use now the exported size of target page (another HACK removal)
> > - created qio_chanel_{wirtev,readv}_all functions.  the _full() name
> >   was already taken.
> >   What they do is the same that the without _all() function, but if it
> >   returns due to blocking it redo the call.
> > - it is checkpatch.pl clean now.
> > 
> > Please comment, Juan.
> 
> High level things,
>   a) I think you probably need to do some bandwidth measurements to show
>     that multifd is managing to have some benefit - it would be good
>     for the cover letter.

Presumably this would be a building block to solving the latency problems
with post-copy, by reserving one channel for use transferring out of band
pages required by target host page faults.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|



reply via email to

[Prev in Thread] Current Thread [Next in Thread]