Re: [Qemu-devel] [PATCH for-2.9 13/47] qapi: Fix QAPISchemaEnumType.is_implicit() for 'QType'

[Eric Blake]

On 03/13/2017 01:18 AM, Markus Armbruster wrote:
> Missed in commit 7264f5c.  Harmless, because nothing checks whether an
> enumeration type is implicit so far.

Obviously, a later patch will care about implicit types, and choked
without this ;)

> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  scripts/qapi.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

> 
> diff --git a/scripts/qapi.py b/scripts/qapi.py
> index e6d023f..7a2b6ab 100644
> --- a/scripts/qapi.py
> +++ b/scripts/qapi.py
> @@ -1148,8 +1148,8 @@ class QAPISchemaEnumType(QAPISchemaType):
>              v.check_clash(self.info, seen)
>  
>      def is_implicit(self):
> -        # See QAPISchema._make_implicit_enum_type()
> -        return self.name.endswith('Kind')
> +        # See QAPISchema._make_implicit_enum_type() and ._def_predefineds()
> +        return self.name.endswith('Kind') or self.name == 'QType'
>  
>      def c_type(self):
>          return c_name(self.name)
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature