[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for 2.9?] hmp: gpa2hva and gpa2hpa hostaddr comm
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH for 2.9?] hmp: gpa2hva and gpa2hpa hostaddr command |
Date: |
Tue, 14 Mar 2017 10:28:36 -0700 (PDT) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Subject: [Qemu-devel] [PATCH for 2.9?] hmp: gpa2hva and gpa2hpa hostaddr command
Message-id: address@hidden
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/address@hidden -> patchew/address@hidden
- [tag update] patchew/address@hidden -> patchew/address@hidden
* [new tag] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
34854e1 hmp: gpa2hva and gpa2hpa hostaddr command
=== OUTPUT BEGIN ===
Checking PATCH 1/1: hmp: gpa2hva and gpa2hpa hostaddr command...
WARNING: line over 80 characters
#71: FILE: monitor.c:1429:
+ error_setg(errp, "No memory is mapped at address 0x%" HWADDR_PRIx,
addr);
WARNING: line over 80 characters
#76: FILE: monitor.c:1434:
+ error_setg(errp, "Memory at address 0x%" HWADDR_PRIx "is not RAM",
addr);
ERROR: space prohibited between function name and open parenthesis '('
#112: FILE: monitor.c:1470:
+ off_t offset = addr / pagesize * sizeof (pinfo);
total: 1 errors, 2 warnings, 147 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden