Re: [Qemu-devel] [PATCH for-2.9 28/47] qapi2texi: Generate descriptions for simple union tags

[Eric Blake]

On 03/13/2017 01:18 AM, Markus Armbruster wrote:
> Simple union tags carry no type information, because their type is
> implicit.  Their description should make up for it, but many have
> none.  Generate one automatically then.
> 
> Example change (qemu-qmp-ref.txt):
> 
>   -- Simple Union: ImageInfoSpecific
> 
>       A discriminated record of image format specific information
>       structures.
> 
>       Members:
>       'type'
> -          Not documented
> +          One of "qcow2", "vmdk", "luks"

Yes, that's nicer.

>       'data: ImageInfoSpecificQCow2' when 'type' is "qcow2"
>       'data: ImageInfoSpecificVmdk' when 'type' is "vmdk"
>       'data: QCryptoBlockInfoLUKS' when 'type' is "luks"
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  scripts/qapi2texi.py | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature